Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround OpaquePointers for LLVM 15 #2367

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Workaround OpaquePointers for LLVM 15 #2367

merged 1 commit into from
Sep 29, 2022

Conversation

toppk
Copy link
Contributor

@toppk toppk commented Sep 26, 2022

This workaround allows bpftrace to be compiled against LLVM-15. This will have to be address properly before LLVM-16
More details from LLVM here: https://llvm.org/docs/OpaquePointers.html

Open issues here:
#2366
#2365

Checklist
  • Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
  • User-visible and non-trivial changes updated in CHANGELOG.md
  • The new behaviour is covered by tests

This workaround allows bpftrace to be compiled against
LLVM-15.  This will have to be address properly before LLVM-16
More details from LLVM here: https://llvm.org/docs/OpaquePointers.html
@hhoffstaette
Copy link

Tested (wrt. #2366) and seems to work. Thanks!

Copy link
Contributor

@viktormalik viktormalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I created the issue #2368 to track the proper fix.

@miwojcik
Copy link
Contributor

Hi @viktormalik! Is this workaround going to be merged or are you working on a proper solution? I hit exactly the same issue (#2365 but on yocto/poky) and this workaround is working, but I wonder if I need to temporary backport it.

@viktormalik
Copy link
Contributor

Since LLVM 15 is already out, I'd suggest to merge this workaround to have a fix until I finish the proper solution.

@danobi, @fbs, @ajor any objections?

@fbs fbs merged commit a277ec4 into bpftrace:master Sep 29, 2022
@fbs
Copy link
Contributor

fbs commented Sep 29, 2022

no, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants