Allow probe builtin with aliased software/hardware probes #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using probe builtin in software/hardware probes specified by alias name
is not possible b/c ProbeMatcher cannot find the match:
# bpftrace -e 'software:cpu:1 { print(probe); exit() }'
No probes to attach
Fix this by adding the aliased name (if exists) to the search list.
viktormalik
force-pushed
the
software-alias-probe-builtin
branch
from
b6f7356
to
abdc5ad
Compare
danobi
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
probebuiltin insoftware/hardwareprobes specified by alias name is not possible b/cProbeMatchercannot find the match:Fix this by adding the aliased name (if exists) to the search list.
Fixes #2700.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md