Add access to CLOCK_MONOTONIC with nsecs(monotonic) #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove some optional parameters to make it easier to understand which test() overload is being used.
This lets users explicitly request CLOCK_MONOTONIC when it is desired to get a timestamp exclusive of suspend time.
xh4n3
reviewed
Aug 22, 2023
| @@ -1337,18 +1332,17 @@ void CodegenLLVM::visit(Call &call) | |||
| if (call.type.ts_mode == TimestampMode::boot || | |||
There was a problem hiding this comment.
could this be:
if (call.type.ts_mode == TimestampMode::sw_tai)
{
uint64_t delta = bpftrace_.delta_taitime_->tv_sec * 1e9 + bpftrace_.delta_taitime_->tv_nsec;
expr_ = b_.CreateAdd(b_.CreateGetNs(TimestampMode::boot, call.loc), b_.getInt64(delta));
}
else
{
expr_ = b_.CreateGetNs(call.type.ts_mode, call.loc);
}| case TimestampMode::boot: | ||
| fn = bpftrace_.feature_->has_helper_ktime_get_boot_ns() | ||
| ? libbpf::BPF_FUNC_ktime_get_boot_ns | ||
| : libbpf::BPF_FUNC_ktime_get_ns; |
There was a problem hiding this comment.
since we let user to be explicit about timestamp mode, should this fallback behavior to be documented, or change it into a loud fatal error?
There was a problem hiding this comment.
Yeah we might want to change some stuff around nsecs()/nsecs(boot), but I'm not sure exactly in what way and wanted to keep this PR simple. We can do this later if any good ideas come up
| @@ -159,7 +159,7 @@ class IRBuilderBPF : public IRBuilder<> | |||
| const bool inverse, | |||
| const location &loc, | |||
| MDNode *metadata); | |||
| CallInst *CreateGetNs(bool boot_time, const location &loc); | |||
| CallInst *CreateGetNs(TimestampMode ts, const location &loc); | |||
| CallInst *CreateGetTaiNs(const location &loc); | |||
There was a problem hiding this comment.
CreateGetTaiNs() should be removed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users explicitly request CLOCK_MONOTONIC when it is desired to get a timestamp exclusive of suspend time.
Includes some refactoring of the semantic analyser
test()overloads and deleted some redundant and out-of-date sections of the reference guide.