Various fixes for CI #2763
Merged
Various fixes for CI #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions runners seem to have updated kernel and the old version of `biosnoop.bt` is no longer necessary. Unfortunately, it looks like this is the case for some runners only, so we cannot universally use neither the old nor the new variant. Let's disable the test for now and revisit later when all runners are updated.
danobi
approved these changes
Sep 14, 2023
|
There's one more new CI failure (probably also caused by the kernel update), I'll add it to this PR, soon. |
viktormalik
added
the
do-not-merge
viktormalik
changed the title
viktormalik
force-pushed
the
ci-biosnoop-disable
branch
from
8cf5e57
to
6246f3c
Compare
We are seeing failures of some simple scripts using manual includes:
# cat script.bt
#include <linux/skbuff.h>
BEGIN {}
# bpftrace script.bt
[...]
/lib/modules/[...]/ibt.h:71:10: error: use of undeclared identifier 'true'
[...]
/lib/modules/[...]/le.h:36:2: error: use of undeclared identifier 'uintptr_t'
Let's improve our parsing of undefined typedefs from Clang diagnostic
messages to be able to pull those typedefs from BTF.
viktormalik
force-pushed
the
ci-biosnoop-disable
branch
from
6246f3c
to
72af8b3
Compare
viktormalik
removed
the
do-not-merge
3 tasks
|
@danobi I added one more CI fix, could you please re-check? Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions runners seem to have updated kernel and the old version of
biosnoop.btis no longer necessary.Unfortunately, it looks like this is the case for some runners only, so we cannot universally use neither the old nor the new variant. Let's disable the test for now and revisit later when all runners are updated.
We're also observing CI failure in
memleak-test.sh. It's not related to the memleak test itself, the bug is inClangParserwhich one of the memleak tests executes:This is fixed by improving our parsing of undefined typedefs from Clang diagnostic messages to be able to pull those typedefs from BTF.
Checklist
man/adoc/bpftrace.adocand if needed indocs/reference_guide.mdCHANGELOG.md