Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address tables: Remove id attribute from root nodes #170

Merged
merged 2 commits into from
Mar 21, 2020
Merged

Address tables: Remove id attribute from root nodes #170

merged 2 commits into from
Mar 21, 2020

Conversation

tswilliams
Copy link
Collaborator

@tswilliams tswilliams commented Mar 16, 2020 •
edited

This pull request:

  • Updates the CI config to use docker containers with uHAL v2.7.2 (which applies stricter checks when parsing address tables)
  • Removes the id attribute from the root node of all address tables in the repo (since the id attribute is never used for root nodes).

tswilliams added a commit that referenced this pull request Mar 16, 2020
@tswilliams
CI: Update to container with uHAL v2.7.2 (stricter address table pars…
f49aaa1 
…ing). See #170
tswilliams added a commit that referenced this pull request Mar 16, 2020
@tswilliams
Address tables: Remove id attribute from root nodes. See #170
492d2d3
@tswilliams tswilliams force-pushed the task/address-tables-remove-root-id branch from 9a7d5df to 492d2d3 Compare March 16, 2020 16:21
@tswilliams tswilliams mentioned this pull request Mar 16, 2020
Closed
@tswilliams tswilliams force-pushed the task/address-tables-remove-root-id branch from 492d2d3 to b3a0e25 Compare March 21, 2020 12:39
@tswilliams
Copy link
Collaborator Author

Run tests, please

@tswilliams tswilliams merged commit dc6f692 into master Mar 21, 2020
@tswilliams tswilliams deleted the task/address-tables-remove-root-id branch March 21, 2020 13:43
@tswilliams tswilliams linked an issue May 15, 2020 that may be closed by this pull request
Missing 'id' attribute in opencores_i2c.xml #162
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrothea alessandrothea Awaiting requested review from alessandrothea alessandrothea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing 'id' attribute in opencores_i2c.xml
1 participant
@tswilliams