Cleanup address overlap checks #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o utility functions; add unit tests. See #206
tswilliams
force-pushed
the
task/cleanup-address-overlap-checks
branch
from
f79e2e1
to
1292599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following feedback that it takes a long time to load some uHAL address tables, I've cleaned up the node overlap check code. Specifically, this branch:
Regarding time taken to load address tables: Before this pull request, on my laptop it took ~ 20 seconds to parse some ATLAS address tables from Murrough Landon (due to a quadratic dependence on the number of nodes). Now it only takes about 0.5 seconds, with the amount of time spent in overlap checks reducing from ~ 20 seconds to ~ 15 milliseconds.