Make the IPBus address decoder generator script accept 'empty nodes' (with tests) #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful when one builds address tables for different firmware images based from the same top-level address table using placeholders. In such cases, any particular placeholder may end up being empty for any given build. Allowing empty nodes is nicer than forcing the use of dummy nodes (which don't exist in hardware, after all). NOTE: This requires a small change in ipbus-firmware as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch rebases #292 and also adds tests of the address decoder generator (since there was little coverage of that in the test suite before).
Original description from #292: