Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette issues #111

Closed
dhersz opened this issue Sep 18, 2020 · 3 comments
Closed

Vignette issues #111

dhersz opened this issue Sep 18, 2020 · 3 comments

Comments

@dhersz
Copy link
Member

dhersz commented Sep 18, 2020

I was checking the vignette on CRAN and realized that when we list the sample files that come with the package the network.dat and .mapdbs are also shown:

image

This leaves me confused, since these files should not exist without running setup_r5. So either setup_r5 is running somewhere during CRAN build or CRAN is cloning our repo with these files already created (not sure how CRAN submission and build works though, just a guess).

@rafapereirabr
Copy link
Member

rafapereirabr commented Sep 18, 2020

Yep, this is puzzling. Specially considering that we do not run any java dependent function on CRAN. It seems they are running the Java functions anyway.

@dhersz
Copy link
Member Author

dhersz commented Feb 11, 2021

From Hadley's R Packages book:

Note that since you build vignettes locally, CRAN only receives the html/pdf and the source code. However, CRAN does not re-build the vignette. It only checks that the code is runnable (by running it).

We should fix it locally.

@dhersz
Copy link
Member Author

dhersz commented Feb 19, 2021

196b042 should fix it.

@dhersz dhersz closed this as completed Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants