Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdx dependency #113

Closed
rafapereirabr opened this issue Sep 23, 2020 · 2 comments
Closed

jdx dependency #113

rafapereirabr opened this issue Sep 23, 2020 · 2 comments

Comments

@rafapereirabr
Copy link
Member

Ou latest CRAN check returns the following error message:

using R version 4.0.2 Patched (2020-09-17 r79226)
using platform: i386-pc-solaris2.10 (32-bit)
using session charset: UTF-8
using option ‘--no-stop-on-test-error’
checking for file ‘r5r/DESCRIPTION’ ... OK
checking extension type ... Package
this is package ‘r5r’ version ‘0.1.0’
package encoding: UTF-8
checking package namespace information ... OK
checking package dependencies ... ERROR
Package required but not available: ‘jdx’

See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
manual.
DONE
Status: 1 ERROR

I couldn't find a way to address this error, so I would appreciate some help here :) Perhaps @floidgilbert could shed some light here, please?

This is how our depencies look like in our DESCRIPTION file.

Suggests:
    covr,
    ggplot2 (>= 3.3.1),
    knitr,
    mapview,
    rmarkdown,
    testthat
Imports:
    checkmate,
    data.table,
    methods,
    jdx (>= 0.1.4),
    rJava (>= 0.9-13),
    sf (>= 0.9-3),
    sfheaders,
    utils
@floidgilbert
Copy link

I haven't encountered that error. A quick Google search shows that it is a common error on CRAN and there appears to be many possible causes. I suggest contacting the folks @ CRAN for suggestions. It's interesting that it fails only on Solaris.

@rafapereirabr
Copy link
Member Author

Uwe confirmed to me that the Solaris server does not have Java Runtime Environment (>= 8). I asked whether this error on Solaris alone should be a problem to keep the package on CRAN. Here is his response:

On 25.09.2020

Ideally move the jdx dependency to "Suggests" if that nmakes sense and
you have funtionality that does not strictly depend on jdx in order to
make your package available on more platforms. If you need it strictly,
that's OK, too.

Best,
Uwe Ligges

Our package does depend on jdx so we are keeping it under Imports. I guess this shouldn't be a big issue. Closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants