Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement temporary solution for elevation #171

Closed
rafapereirabr opened this issue May 21, 2021 · 7 comments · Fixed by #175
Closed

Implement temporary solution for elevation #171

rafapereirabr opened this issue May 21, 2021 · 7 comments · Fixed by #175
Assignees
Labels

Comments

@rafapereirabr
Copy link
Member

Ideally, we would like to see an solution that accounts for elevation implemented upstream in R5. In the meantime, we will be implementing a temporary solution in r5r. More info about this temporary solution in this issue.

@rafapereirabr
Copy link
Member Author

Setting this issue as priority, to be incorporated in the next package release.

@rafapereirabr
Copy link
Member Author

I've added included a couple lines of code to checkmate::assert_ inputs. I've also added some tests to the elevation functions.

@rafapereirabr
Copy link
Member Author

@mvpsaraiva , does this temporary solution only work for walking (see function description) ? or does it affect cycling speeds/routing as well?

#' Tobler's hiking function
#'
#' @description Calculates effect of the topography on walking speeds, using
#'              Tobler's hiking function.

@rafapereirabr
Copy link
Member Author

I've also updated the NEWs file

@rafapereirabr
Copy link
Member Author

this issue will be closed once we merge dev and master branches

@mvpsaraiva
Copy link
Collaborator

@mvpsaraiva , does this temporary solution only work for walking (see function description) ? or does it affect cycling speeds/routing as well?

Tobler's hiking function works for walking trips only. The code for weighting cycling trips is in the Java side, inside the jar.

@rafapereirabr
Copy link
Member Author

Ok , thanks for the clarification !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants