Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid code in session.go #12

Closed
chrisprobst opened this issue Mar 27, 2017 · 4 comments
Closed

Invalid code in session.go #12

chrisprobst opened this issue Mar 27, 2017 · 4 comments

Comments

@chrisprobst
Copy link

Latest commit just broke the entire library:

https://github.com/ipfans/echo-session/blob/master/session.go#L67

Your current head IS NOT compatible with echo v3. There is no Writer() function. Please fix and revert. Your lib is broken now!

CHECK:
https://github.com/labstack/echo/blob/master/response.go#L14

@ijust
Copy link
Contributor

ijust commented Mar 28, 2017

Latest commit is pre-release.
https://github.com/labstack/echo/releases

In stable latest release, it is compatible.
https://github.com/labstack/echo/blob/v3.0.3/response.go#L14

Fix this problem, Please not revert and set git tags for vendoring properly.

@ipfans
Copy link
Owner

ipfans commented Mar 29, 2017

I think it is a good point that golang need a package management tool. 😄

If you use glide(or other package management tool like dep ), please use v3.0.0-rc1 instead of master branch.

@carynova
Copy link
Contributor

to fix it just delete the '()'
s := &session{name, rq, store, nil, false, rs.Writer}

@carynova carynova mentioned this issue May 22, 2017
@meekmichael
Copy link

Could a v3.0.0-rc2 be made with this PR plus the current master with the Postgres session code in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants