Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adder: try to make test less flaky #1462

Merged
merged 1 commit into from Aug 30, 2021
Merged

Adder: try to make test less flaky #1462

merged 1 commit into from Aug 30, 2021

Conversation

hsanjuan
Copy link
Collaborator

@hsanjuan hsanjuan commented Aug 28, 2021 •
edited

Fixes #1461

@hsanjuan hsanjuan added this to the Release v0.14.2 milestone Aug 28, 2021
@hsanjuan hsanjuan mentioned this pull request Aug 28, 2021
Closed
@Luflosi
Copy link

Luflosi commented Aug 29, 2021

Instead of making it "less flaky", would it be possible to make it absolutely 100% reliable?

@hsanjuan
Copy link
Collaborator Author

Everything is possible. But I don't have time for everything so I'm happy with the 99.9%.

@hsanjuan hsanjuan merged commit 396a348 into master Aug 30, 2021
@hsanjuan hsanjuan deleted the fix/1461-flaky-test branch August 30, 2021 10:04
@Luflosi
Copy link

Luflosi commented Aug 30, 2021

You should update the comment as well.

@amroset27
Copy link

  • nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amroset27 amroset27 amroset27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v0.14.2
Development

Successfully merging this pull request may close these issues.

TestAdder_ContextCancelled seems to be flaky
3 participants
@hsanjuan @Luflosi @amroset27