Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for the dockerfile #200

Closed
hsanjuan opened this issue Oct 26, 2017 · 1 comment
Closed

Add a test for the dockerfile #200

hsanjuan opened this issue Oct 26, 2017 · 1 comment
Assignees
@ZenGround0
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up

Comments

@hsanjuan
Copy link
Collaborator

make docker

Should:

  • Make sure the dockerfile builds correctly
  • Make sure cluster-service returns correct version
  • Make sure cluster-ctl returns correct version
  • At least...

It should prevent things like #196 from happening...
@hsanjuan hsanjuan added exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked labels Oct 26, 2017
@hsanjuan hsanjuan added this to the All open issues with difficulty:medium or lower are fixed [Q4O1] milestone Oct 26, 2017
@hsanjuan hsanjuan mentioned this issue Oct 31, 2017
Closed
@ZenGround0 ZenGround0 mentioned this issue Jan 4, 2018
Merged
@ZenGround0 ZenGround0 self-assigned this Jan 5, 2018
@hsanjuan
Copy link
Collaborator Author

hsanjuan commented Jan 8, 2018

@ZenGround0 closeable?

@ghost ghost removed the status/ready Ready to be worked label Jan 8, 2018
@hsanjuan hsanjuan mentioned this issue Jan 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZenGround0 ZenGround0

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsanjuan @ZenGround0