Raft: do not ever remove state, rename it and leave it around #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the way that consensus.Clean() works. Before it deleted the whole data folder. Now it renames it as <name>.old.0 and leaves it. When Clean() is called again, it renames <name>.old.0 as <name>.old.1, and the actual data becomes <name>.old.0. Higher number means older. The number of backups is fixed to 5. When 5 backups exists and a new one comes up again, the last one is discarded. License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
ghost
assigned 
hsanjuan
added
need/review
Closed
ZenGround0
requested changes
Nov 14, 2017
consensus/raft/data_helper_test.go
Outdated
| } | ||
| backups := helper.listBackups() | ||
| if i < RaftDataBackupKeep && len(backups) != i+1 { | ||
| t.Fatal("not saving enough backups") |
There was a problem hiding this comment.
If something really weird happened with the helper and too many backups were saved before iteration RaftDataBackupKeep or alternatively too few backups were saved after iteration RaftDataBackupKeep, then the error messages will be misleading. As the check stands, a better message would be "incorrect number of backups saved"
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
ZenGround0
approved these changes
Nov 14, 2017
|
LGTM |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way that consensus.Clean() works. Before
it deleted the whole data folder. Now it renames it as .old.0
and leaves it. When Clean() is called again, it renames .old.0
as .old.1, and the actual data becomes .old.0. Higher number
means older. The number of backups is fixed to 5. When 5 backups exists
and a new one comes up again, the last one is discarded.
License: MIT
Signed-off-by: Hector Sanjuan hector@protocol.ai