cluster-service: add version subcommand and change some startup logging #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ZenGround0
requested changes
Dec 12, 2017
consensus/raft/raft.go
Outdated
| err := hraft.BootstrapCluster(cfg.RaftConfig, | ||
| log, stable, snap, transport, srvCfg) | ||
| if err != nil { | ||
| logger.Error("bootstrapping cluster: ", err) | ||
| return nil, err | ||
| } | ||
| } else { | ||
| logger.Info("raft cluster is already bootstrapped") | ||
| logger.Debug("raft cluster is already bootstrapped") |
There was a problem hiding this comment.
As you changed bootstrapping to initializing above it seems like you should do it here too for consistency.
| @@ -86,7 +86,7 @@ func NewCluster( | |||
| return nil, err | |||
| } | |||
|
|
|||
| logger.Infof("IPFS Cluster v%s listening on:", Version) | |||
| logger.Infof("IPFS Cluster v%s-%s listening on:", Version, Commit[0:8]) | |||
There was a problem hiding this comment.
As TestClusterStateSync doesn't hit the cluster service version command this slice dereference seems to be the cause of the slice out of bounds error that Travis catches for these changes.
The --version flag is default from our cli library so I left that. The version subcommand prints only the version number + the short commit so it's a bit more easy to parse. I have additionally reduced the amount of output on start up by converting some messages to debug. I wish there was a level between INFO and DEBUG though. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
hsanjuan
force-pushed
the
feat/201-version-subcmd
branch
from
5c514a7
to
2b6dfa4
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --version flag is default from our cli library so I left that. The
version subcommand prints only the version number + the short commit
so it's a bit more easy to parse.
I have additionally reduced the amount of output on start up by converting
some messages to debug. I wish there was a level between INFO and DEBUG
though.
Fixes #201
License: MIT
Signed-off-by: Hector Sanjuan code@hector.link