Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/recursive pins #342

Merged
merged 3 commits into from Mar 12, 2018
Merged

Feat/recursive pins #342

merged 3 commits into from Mar 12, 2018

Conversation

ZenGround0
Copy link
Collaborator

@hsanjuan the second half of the proposal in #325, this time with a migration from state format 3 to 4 and merging into master.

@ghost ghost assigned ZenGround0 Mar 9, 2018
@ghost ghost added the status/in-progress In progress label Mar 9, 2018
hsanjuan
hsanjuan requested changes Mar 9, 2018
View reviewed changes
Copy link
Collaborator

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, fix tests first :)

@coveralls
Copy link

coveralls commented Mar 9, 2018 •
edited

Coverage Status

Coverage increased (+0.04%) to 67.713% when pulling d7d2dca on feat/recursive-pins into c276c31 on master.

@ZenGround0
Copy link
Collaborator Author

@hsanjuan Travis passes now

@ZenGround0 ZenGround0 requested a review from hsanjuan March 9, 2018 21:59
@hsanjuan
Copy link
Collaborator

@ZenGround0 nope:

./cluster_test.go:106:23: cannot use ipfs (type *mockConnector) as type IPFSConnector in argument to NewCluster:
	*mockConnector does not implement IPFSConnector (wrong type for Pin method)
		have Pin(*cid.Cid) error
		want Pin(*cid.Cid, bool) error
FAIL	github.com/ipfs/ipfs-cluster [build failed]

it's because travis doesn't detect failures

@ZenGround0
support for recursive pins
1b7b918 
extension to api types
modifications to ipfsconnector

License: MIT
Signed-off-by: Wyatt Daviau <wdaviau@cs.stanford.edu>
@ZenGround0
Migration to state specifying recursive attribute
bdc373d 
License: MIT
Signed-off-by: Wyatt Daviau <wdaviau@cs.stanford.edu>
@ZenGround0
fix errors
d7d2dca 
License: MIT
Signed-off-by: Wyatt Daviau <wdaviau@cs.stanford.edu>
@ZenGround0
Copy link
Collaborator Author

ZenGround0 commented Mar 12, 2018 •
edited

@hsanjuan Now this should be good to go, though one of the travis runs fails on the unrelated buggy test "TestClustersReplication".

@hsanjuan
Copy link
Collaborator

I have retriggered the tests, will wait until they pass

@ZenGround0 ZenGround0 merged commit 05b6448 into master Mar 12, 2018
@ghost ghost removed the status/in-progress In progress label Mar 12, 2018
@hsanjuan hsanjuan deleted the feat/recursive-pins branch March 12, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanjuan hsanjuan hsanjuan approved these changes

Assignees

@ZenGround0 ZenGround0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZenGround0 @coveralls @hsanjuan