Docker: Run with daemon --upgrade by default. #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ZenGround0
reviewed
Apr 27, 2018
| @@ -20,10 +20,15 @@ ipfs-cluster-service --version | |||
| if [ -e "${IPFS_CLUSTER_PATH}/service.json" ]; then | |||
| echo "Found IPFS cluster configuration at ${IPFS_CLUSTER_PATH}" | |||
| else | |||
| echo "This container only runs ipfs-cluster-service. ipfs needs to be run separately!" | |||
ZenGround0
reviewed
Apr 27, 2018
docker/entrypoint.sh
Outdated
| ipfs-cluster-service init | ||
| if [ -n "$IPFS_API" ]; then | ||
| echo "Using \$IPFS_API as value for node_multiaddress in configuration" |
There was a problem hiding this comment.
Already great, but to make this crystal clear say "... as value for the ipfs_connector node_multiaddress". It's hard for newcomers to keep track of all the different nodes and uses of the word node so calling out that this is the IPFS node's address will help those who don't want to dig into the config file.
ZenGround0
approved these changes
Apr 27, 2018
Plus add some warnings for users running the container randomly. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
hsanjuan
force-pushed
the
docker/run-daemon-default
branch
from
fd42968
to
2fa41e7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus add some warnings for users running the container randomly.
License: MIT
Signed-off-by: Hector Sanjuan code@hector.link