Fix #408: Race condition when StateSync runs #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Disregard Windows failures in jenkins |
hsanjuan
added
need/review
Closed
lanzafame
suggested changes
May 12, 2018
pintracker/maptracker/maptracker.go
Outdated
| return nil // cancelled while in queue, all done | ||
| case opc.op == operationUnpin && opc.phase == phaseInProgress: | ||
| mpt.optracker.finish(c.Cid) | ||
| // cancelled while unpinning: continue and trigger unpin |
There was a problem hiding this comment.
s/trigger unpin/trigger pin
When StateSync() runs and triggers Untrack() on items that have just been removed from the state but on which Untrack() is underway, the operation tracker would be reset to phase queued and in some cases stay so. Also happened for Track() This caused failures of TestClustersPin as SyncStatus() is triggered regularly while Tracks() and Untracks() happen. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
hsanjuan
force-pushed
the
fix/408-TestClustersPin-final
branch
from
68555ec
to
73aabfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When StateSync() runs and triggers Untrack() on items
that have just been removed from the state but on which
Untrack() is underway, the operation tracker would be
reset to phase queued and in some cases stay so.
Also happened for Track()
This caused failures of TestClustersPin as SyncStatus()
is triggered regularly while Tracks() and Untracks() happen.
License: MIT
Signed-off-by: Hector Sanjuan code@hector.link