Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin context timing out too soon #421

Closed
hsanjuan opened this issue May 14, 2018 · 2 comments
Closed

Pin context timing out too soon #421

hsanjuan opened this issue May 14, 2018 · 2 comments
Assignees
@lanzafame
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@hsanjuan
Copy link
Collaborator

I have noticed that when I do recover on a pin, the state soon becomes:

> Peer QmPDJG7Lw7b7QuyR5MtTTHToewfRcAWWBN6Nw58wcog8uW : ERROR | net/http: request canceled (Client.Timeout exceeded while reading body)

Instead of just stay pinning (for at least 24h, which is the PinTimeout set).

I am not sure if this affects all pins, or why. The Client.Timeout should not be exceeded so soon. It's either not picked correctly from the config section, or something weird is going on. I can't see where upon a preliminary check.

We set IPFSRequestTimeout as a general Timeout propertly for the http client in the ipfsconn. This makes all requests timeout after 5 minutes (including pins and unpins, which should have their own, longer timeouts).
@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up labels May 14, 2018
@hsanjuan
Copy link
Collaborator Author

@lanzafame would you mind fixing this one?

@hsanjuan
Copy link
Collaborator Author

Fixed in #427

@ghost ghost removed the status/ready Ready to be worked label May 27, 2018
@hsanjuan hsanjuan mentioned this issue May 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lanzafame lanzafame

Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsanjuan @lanzafame