Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #428: Use a regexp to match for indirect status in IPFSPinStatusF… #436

Merged
merged 2 commits into from May 27, 2018

Conversation

Laevos
Copy link
Collaborator

@Laevos Laevos commented May 26, 2018

…romString()

Since indirect pins are of the form indirect through <cid>, let's use
a regexp to match them instead of an equality operator.

License: MIT
Signed-off-by: Lilith McMullen iggnsthe@live.com

…FSPinStatusFromString()

Since indirect pins are of the form `indirect through <cid>`, let's use
a regexp to match them instead of an equality operator.

License: MIT
Signed-off-by: Lilith McMullen <iggnsthe@live.com>
@GitCop
Copy link

GitCop commented May 26, 2018

There were the following issues with your Pull Request

  • Commit: 2429c86
  • Invalid signoff. Commit message must end with
    License: MIT
    Signed-off-by:

Guidelines are available at https://github.com/ipfs/ipfs-cluster/blob/master/contribute.md


This message was auto-generated by https://gitcop.com

License: MIT
Signed-off-by: Lilith McMullen <iggnsthe@live.com>
Copy link
Collaborator

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@hsanjuan hsanjuan merged commit c4c6e17 into ipfs-cluster:master May 27, 2018
@hsanjuan hsanjuan mentioned this pull request May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants