Issue #340: fix some data races #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
hsanjuan
changed the title
hsanjuan
force-pushed
the
fix/340-races
branch
from
0ef5c1e
to
52c4c99
Compare
Unfortunately, there are still some data races in yamux libp2p/go-libp2p#396 so we can't enable this by default. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
hsanjuan
force-pushed
the
fix/340-races
branch
from
52c4c99
to
5bbc699
Compare
hsanjuan
changed the title
|
@lanzafame should merge these fixes, even without enabling -race. better than nothing. |
lanzafame
approved these changes
Aug 17, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #340, still some failures coming from go-logging.This fixes some of the data races identified when running with
-race. Unfortunately, there are still data races in libp2p that we cannot take care of for the moment.