Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up building docker image #529

Merged
merged 1 commit into from Sep 24, 2018
Merged

speed up building docker image #529

merged 1 commit into from Sep 24, 2018

Conversation

lanzafame
Copy link
Contributor

@lanzafame lanzafame commented Sep 7, 2018

By using gx install --local, deps are copied into
the build context and therefore only stale deps
will get pulled from the network on image build.


This change is Reviewable

@GitCop
Copy link

GitCop commented Sep 7, 2018

There were the following issues with your Pull Request

  • Commit: d523f16
  • Invalid signoff. Commit message must end with
    License: MIT
    Signed-off-by:

Code contribution guidelines for IPFS Cluster are available at https://cluster.ipfs.io/developer/contribute/#code-contribution-guidelines


This message was auto-generated by https://gitcop.com

@ghost ghost assigned lanzafame Sep 7, 2018
@ghost ghost added the status/in-progress In progress label Sep 7, 2018
@coveralls
Copy link

coveralls commented Sep 7, 2018

Coverage Status

Coverage remained the same at 65.132% when pulling 88f08e8 on feat/docker-gx-make into 753322c on master.

By using gx install --local, deps are copied into
the build context and therefore only stale deps
will get pulled from the network on image build.

License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
@hsanjuan hsanjuan added RFM Ready for Merge and removed status/in-progress In progress labels Sep 7, 2018
@hsanjuan hsanjuan merged commit e751fbe into master Sep 24, 2018
@hsanjuan hsanjuan deleted the feat/docker-gx-make branch September 24, 2018 11:51
@hsanjuan hsanjuan mentioned this pull request Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFM Ready for Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants