Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #543: Use only healthy peers when adding everywhere (+tests) #549

Merged
merged 1 commit into from Sep 27, 2018
Merged

Fix #543: Use only healthy peers when adding everywhere (+tests) #549

merged 1 commit into from Sep 27, 2018

Conversation

hsanjuan
Copy link
Collaborator

Fixes #543 .

@hsanjuan hsanjuan self-assigned this Sep 26, 2018
@ghost ghost added the status/in-progress In progress label Sep 26, 2018
@coveralls
Copy link

coveralls commented Sep 26, 2018 •
edited

Coverage Status

Coverage increased (+0.08%) to 65.196% when pulling e7b1eac on fix/543-add-unhealthy into 2279856 on master.

lanzafame
lanzafame suggested changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@lanzafame lanzafame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the typo and then good to go.

cluster_test.go Outdated
@@ -255,7 +255,7 @@ func TestClusterPin(t *testing.T) {
}
}

func TestAddFile(t *testing.T) {
func TestAddesFile(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/TestAddesFile/TestAddsFile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops, sorry

@hsanjuan
Fix #543: Use only healthy peers when adding everywhere (+tests)
e7b1eac 
License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
@hsanjuan
Copy link
Collaborator Author

@lanzafame ok now

@hsanjuan hsanjuan merged commit 398cdaa into master Sep 27, 2018
@hsanjuan hsanjuan deleted the fix/543-add-unhealthy branch September 27, 2018 14:52
@ghost ghost removed the status/in-progress In progress label Sep 27, 2018
@hsanjuan hsanjuan mentioned this pull request Oct 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanzafame lanzafame lanzafame approved these changes

Assignees

@hsanjuan hsanjuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsanjuan @coveralls @lanzafame