api/rest: change *cid.Cid to cid.Cid in client iface #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanzafame
added
need/review
ghost
assigned
Closed
4 tasks
hsanjuan
requested changes
Oct 1, 2018
There was a problem hiding this comment.
ouch. maybe should force tests against latest master before merging.
@lanzafame tests are failing here though, think you forgot some updates.
lanzafame
force-pushed
the
fix/client-cid-pointer
branch
from
393eb12
to
33005ec
Compare
Closed
License: MIT Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
hsanjuan
force-pushed
the
fix/client-cid-pointer
branch
from
33005ec
to
e86fefb
Compare
|
Fixed myself |
|
hahah woops sorry should have pinged you that I had already pushed up the changes. Was just waiting for tests to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#523 added a new interface and was written before the
*cid.Cidtocid.CidPR so rebasing didn't update anything.@hsanjuan Could you please prioritize this PR? Thanks in advance.