Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubsubmon: Gossipsub #573

Merged
merged 2 commits into from Oct 18, 2018
Merged

Pubsubmon: Gossipsub #573

merged 2 commits into from Oct 18, 2018

Conversation

hsanjuan
Copy link
Collaborator

Uh oh

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
@hsanjuan hsanjuan self-assigned this Oct 10, 2018
@ghost ghost added the status/in-progress In progress label Oct 10, 2018
@hsanjuan
Copy link
Collaborator Author

:-( @vyzo so 1 test with just 2 peers, one of them does Publish but the other one doesn't seem to receive any message.

However, things seem to work fine on the tests with multiple peers (6) and which would fail if things didn't reach all of them.

@vyzo
Copy link

vyzo commented Oct 10, 2018

You probably want to lower the initial heartbeat delay for the tests, because it takes a 100ms before the overlay is ready to use -- see GossipSubHeartbeatInitialDelay

@coveralls
Copy link

coveralls commented Oct 10, 2018

Coverage Status

Coverage increased (+0.01%) to 65.354% when pulling fcbfc7f on feat/gossipsub into f65349e on master.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
@hsanjuan hsanjuan mentioned this pull request Oct 18, 2018
@hsanjuan hsanjuan merged commit 3c9945f into master Oct 18, 2018
@hsanjuan hsanjuan deleted the feat/gossipsub branch October 18, 2018 10:07
@ghost ghost removed the status/in-progress In progress label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants