Fix/update json config #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonConfigs.getSection() returned a value when it needed to return a pointer to the jsonSection fields inside the struct. Even though the jsonSection type is a map, therefore on the heap, returning it as a value (non-pointer) resulted in it being disassociated with the jsonConfigs overarching struct. License: MIT Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
License: MIT Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
lanzafame
added
kind/bug
ghost
added
the
Closed
License: MIT Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
hsanjuan
requested changes
Feb 6, 2019
|
I don't know why the docker compose thing is failing but I'll check |
|
ah @lanzafame , docker compose is probably failing because the container |
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #658.
jsonConfigs.getSection() returned a value when it needed to
return a pointer to the jsonSection fields inside the struct.
Even though the jsonSection type is a map, therefore on the heap,
returning it as a value (non-pointer) resulted in it being
disassociated with the jsonConfigs overarching struct.
License: MIT
Signed-off-by: Adrian Lanzafame adrianlanzafame92@gmail.com