Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning that configuration with environment variables for cluster wont show in service.json #667

Closed
petscheit opened this issue Jan 29, 2019 · 2 comments

Comments

@petscheit
Copy link

As I learned today, when configuring the ipfs-cluster-service with environment variables not all changes will be written to service.json, while others are.
For example, when setting the CLUSTER_SECRET environment variable, the secret will be written to the service.json file. When setting other variables like CLUSTER_REPLICATIONFACTORMIN the changed will take affect, but wont be written to service.json. I think it's pretty confusing and should be mentioned in the docs.

@daviddias daviddias transferred this issue from ipfs-inactive/website Feb 13, 2019
@hsanjuan
Copy link
Collaborator

Hi, we are working on a better approach at #663 where behaviour will be what you expect.

@hsanjuan
Copy link
Collaborator

Just merged #663 so this should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants