Fix context cancelled too early. #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every 10th pin the ipfs connector calls repo stat. Because the call is async, the context was cancelled immediately and failed. License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
ghost
assigned 
|
@hsanjuan can you please do the context wrapping as done in cluster.go
Shutdown()
…On Sat., 16 Feb. 2019, 04:48 Hector Sanjuan, ***@***.***> wrote:
@hsanjuan <https://github.com/hsanjuan> requested your review on: #676
<#676> Fix context cancelled too
early..
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#676 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFpnaNJz6Sw367k5im8sMOEdYxESzfJWks5vNwD4gaJpZM4a-Odr>
.
|
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
lanzafame
approved these changes
Feb 16, 2019
|
Need to reference this in #650 and changelog |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every 10th pin the ipfs connector calls repo stat.
Because the call is async, the context was cancelled immediately and failed.
@lanzafame for 0.9.0