Remove *Serial types. Use pointers for all types. #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes advantange of the latest features in go-cid, peer.ID and go-multiaddr and makes the Go types serializable by default. This means we no longer need to copy between Pin <-> PinSerial, or ID <-> IDSerial etc. We can now efficiently binary-encode these types using short field keys and without parsing/stringifying (in many cases it just a cast). We still get the same json output as before (with minor modifications for Cids). This should greatly improve Cluster performance and memory usage when dealing with large collections of items. License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
ghost
assigned 
|
It has been HORRIBLE to do this, but I think we had to do it sooner or later. I'm super glad we have so many tests. The main things here are in |
hsanjuan
commented
Feb 27, 2019
api/rest/restapi_test.go
Outdated
| makeGet(t, rest, url(rest)+"/id", &id) | ||
| if id.ID != test.TestPeerID1.Pretty() { | ||
| if id.ID.Pretty() != test.TestPeerID1.Pretty() { |
There was a problem hiding this comment.
we could do id.ID == test.TestPeerID1 but that's depending on the fact that peer IDs are strings, which may change. Ideailly, IDs should provide an Equals method, like Cids do.
| ifaces := make([]interface{}, len(in), len(in)) | ||
| for i := range in { | ||
| ifaces[i] = &in[i] | ||
| in[i] = &api.ID{} |
There was a problem hiding this comment.
not doing this causes very bad errors
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
|
Since now we can work with |
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan
changed the title
|
Fixes #654 |
This was referenced Feb 27, 2019
Closed
lanzafame
suggested changes
Mar 1, 2019
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantange of the latest features in go-cid, peer.ID and
go-multiaddr and makes the Go types serializable by default.
This means we no longer need to copy between Pin <-> PinSerial, or ID <->
IDSerial etc. We can now efficiently binary-encode these types using short
field keys and without parsing/stringifying (in many cases it just a cast).
We still get the same json output as before (with minor modifications for
Cids).
This should greatly improve Cluster performance and memory usage when dealing
with large collections of items.
License: MIT
Signed-off-by: Hector Sanjuan hector@protocol.ai