Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster: allow/run multiple Informer components #940

Closed
hsanjuan opened this issue Oct 12, 2019 · 0 comments · Fixed by #962
Closed

Cluster: allow/run multiple Informer components #940

hsanjuan opened this issue Oct 12, 2019 · 0 comments · Fixed by #962
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@hsanjuan
Copy link
Collaborator

Describe the feature you are proposing

Currently we only allow one Informer component and one Allocator component. As part of improving allocation system, it seems reasonable to just allow multiple informers (juts like we allow multiple API components). An informer should be enabled by appearing in the configuration (like APIs). Informers are just letting the peer broadcast metrics (the logic for the single informer used is in cluster.go).
@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Oct 12, 2019
@kishansagathiya kishansagathiya mentioned this issue Nov 17, 2019
Merged
@hsanjuan hsanjuan mentioned this issue Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow and run multiple informer components ipfs-cluster/ipfs-cluster
1 participant
@hsanjuan