Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a flag to 'add' and 'pin' to avoid pinning them locally #997

Open
RubenKelevra opened this issue Jan 23, 2020 · 3 comments
Open

add a flag to 'add' and 'pin' to avoid pinning them locally #997

RubenKelevra opened this issue Jan 23, 2020 · 3 comments
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@RubenKelevra
Copy link
Collaborator

Describe the feature you are proposing

It would be nice if we can specify a flag which changes the allocation for the cluster, to exclude the local peer from beeing selected as a pinning member.

Would be nice if we can also exclude all trusted nodes.

Naming ideas:

--no-local-pin
--no-trusted-nodes-pin

Feel free to use different ones, since those are probably not good.

Usecases

If you got a cluster with a lot of traffic, you might want to avoid that the local node gets selected as pin, to avoid that it has to provide data for read operations.

This can speed up the cluster's write operations, because there's more bandwidth available to write new data to the cluster.

It also reduces the amount of traffic needed to run a trusted node, which might matter in terms of traffic costs.

@RubenKelevra RubenKelevra added kind/enhancement A net-new feature or improvement to an existing feature need/review Needs a review labels Jan 23, 2020
@hsanjuan
Copy link
Collaborator

So something like an Exclude pin option that blacklist peer IDs for allocations.

@hsanjuan hsanjuan added exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue status/ready Ready to be worked and removed need/review Needs a review labels Jan 27, 2020
@RubenKelevra
Copy link
Collaborator Author

Yes, exactly.

@RubenKelevra
Copy link
Collaborator Author

@hsanjuan this would also reduce the IO in my use-case: I add all the data to my MFS, and when I changed everything I run the pinning operation with ipfs-cluster-ctl pin update followed by an ipfs-cluster-ctl pin rm of the old cluster pin.

Since I cannot set --no-local-pin on my cluster, my local node will start analyzing the full pin, which takes like 4 minutes even on an SSD:

Screenshot_20210323_140355-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

2 participants