Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support testing on bun #18

Merged
merged 5 commits into from
Apr 23, 2024
Merged

feat: support testing on bun #18

merged 5 commits into from
Apr 23, 2024

Conversation

achingbrain
Copy link
Contributor

Run node tests with bun using env var NODE_EXEC=bun

@achingbrain
Copy link
Contributor Author

Bah, it's broken on Windows, support might be added in a week or so - https://twitter.com/bunjavascript/status/1753267105909416079

@achingbrain achingbrain mentioned this pull request Feb 8, 2024
Open
SgtPooki
SgtPooki approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@SgtPooki SgtPooki left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good with this. Do we want to wait and see on bun+windows before merge?

we should wait on this until bun+windows.. https://github.com/ipfs-examples/test-ipfs-example/actions/runs/7831891366/job/21369332451?pr=18

@salieflewis
Copy link

good with this. Do we want to wait and see on bun+windows before merge?

we should wait on this until bun+windows.. https://github.com/ipfs-examples/test-ipfs-example/actions/runs/7831891366/job/21369332451?pr=18

Bun supports Windows 10 and later as of 1.1

https://bun.sh/blog/bun-v1.1

SgtPooki
SgtPooki requested changes Apr 9, 2024
View reviewed changes
test/bun.spec.ts Outdated
Comment on lines 9 to 13
if (platform() === 'win32') {
it.skip('bun does not run on windows', () => {})

return
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (platform() === 'win32') {
it.skip('bun does not run on windows', () => {})
return
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing changes in #19

@SgtPooki SgtPooki mentioned this pull request Apr 15, 2024
Merged
@achingbrain achingbrain merged commit 73085b7 into main Apr 23, 2024
19 checks passed
@achingbrain achingbrain deleted the feat/support-testing-on-bun branch April 23, 2024 07:36
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
e8b43af 
## [1.3.0](v1.2.1...v1.3.0) (2024-04-23)

### Features

* support testing on bun ([#18](#18)) ([73085b7](73085b7))
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
0216fac 
## [1.3.0](v1.2.1...v1.3.0) (2024-04-23)

### Features

* support testing on bun ([#18](#18)) ([73085b7](73085b7))

### Trivial Changes

* update workflow ([b3f87d5](b3f87d5))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki requested changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achingbrain @salieflewis @SgtPooki