Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

dist/{ipfsapi.js, ipfsapi.min.js} not actually compiled #113

Closed
victorb opened this issue Nov 14, 2015 · 5 comments
Closed

dist/{ipfsapi.js, ipfsapi.min.js} not actually compiled #113

victorb opened this issue Nov 14, 2015 · 5 comments
Labels

Comments

@victorb
Copy link
Contributor

victorb commented Nov 14, 2015

The files dist/ipfsapi.min.js and dist/ipfsapi.js are not containing the libraries code anymore, since commit f6a7da6. The only thing I can see in the files is the standard browserify code, without anything about ipfs. Seems like we're missing to source the correct files in the build-step.

@victorb victorb added the bug label Nov 14, 2015
@victorb
Copy link
Contributor Author

victorb commented Nov 14, 2015

ping @dignifiedquire (last commit on files)

@dignifiedquire
Copy link
Contributor

😓

@dignifiedquire
Copy link
Contributor

one of the reasons why I hate having compiled files checked into git..

@victorb
Copy link
Contributor Author

victorb commented Nov 14, 2015

Agreed, if possible, we should not have built files into scm. As @dignifiedquire mentioned in IRC, we can make use of https://npmcdn.com/ that allows us to include the dist/ folder in our published package but not in the scm. To me making use of that makes sense.

@daviddias
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants