feat: support 'create' constructor from ipfs-http-client #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hacdias
commented
Aug 24, 2021
•
hacdias
commented
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
5 tasks
hacdias
changed the title
lidel
requested changes
Aug 31, 2021
src/providers/http-client.js
Outdated
| @@ -61,7 +61,7 @@ async function tryHttpClient ({ loadHttpClientModule, apiAddress, root, connecti | |||
| // Returns js-ipfs-http-client instance or null | |||
| async function maybeApi ({ apiAddress, connectionTest, httpClient, ...options }) { | |||
| try { | |||
| const ipfs = httpClient({ ...options, ...clientOptions(apiAddress) }) | |||
| const ipfs = httpClient.create({ ...options, ...clientOptions(apiAddress) }) | |||
There was a problem hiding this comment.
A bit unfortunate that this will break old code in demos and hackpads that naively load the latest version:
<script src="https://cdn.jsdelivr.net/npm/ipfs-core/dist/index.min.js"></script>
<script src="https://cdn.jsdelivr.net/npm/ipfs-http-client/dist/index.min.js"></script>Can we add the old version inside the catch block, as a fallback attempt?
(ipfs-provider aims to smooth out rough edges introduced by breaking changes in js-ipfs*)
There was a problem hiding this comment.
Done. It's now backwards compatible!
hacdias
changed the title
lidel
changed the title
|
Shipped in v2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.