Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

feat: key tests #180

Merged
merged 2 commits into from
Dec 10, 2017
Merged

feat: key tests #180

merged 2 commits into from
Dec 10, 2017

Conversation

richardschneider
Copy link
Contributor

@richardschneider richardschneider commented Dec 9, 2017 •
edited

@ghost ghost assigned richardschneider Dec 9, 2017
@ghost ghost added the in progress label Dec 9, 2017
daviddias
daviddias suggested changes Dec 9, 2017
View reviewed changes
Copy link
Contributor

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating tests for this. Please update the SPEC folder with a KEY.md and function descriptions as well.

@richardschneider
Copy link
Contributor Author

@diasdavid added docs

daviddias
daviddias approved these changes Dec 10, 2017
View reviewed changes
Copy link
Contributor

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽👏🏽

@daviddias
Copy link
Contributor

Excellent work!

@daviddias daviddias merged commit b75e13b into master Dec 10, 2017
@daviddias daviddias deleted the keychain branch December 10, 2017 09:50
@ghost ghost removed the in progress label Dec 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@richardschneider richardschneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richardschneider @daviddias