This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: use new ipfsd-ctl #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
suggested changes
Dec 21, 2017
src/block.js
Outdated
| expect(err).to.not.exist() | ||
| ipfs = node | ||
| ipfsd = node | ||
| done() | ||
| }) |
There was a problem hiding this comment.
You are forgetting that these tests are also run by js-ipfs core. Replace df.spawn call line by:
df.spawn((err, _ipfsd) => {
expect(err).not.to.exist()
ipfsd = _ipfsd
ipfs = _ipfsd.api
})
And avoid replacing all the lines in tests.
dryajov
force-pushed
the
feat/ipfsd-ctl
branch
from
1aa0338
to
c57f5c7
Compare
Merged
6 tasks
dryajov
force-pushed
the
feat/ipfsd-ctl
branch
from
6c463e1
to
b3e3fab
Compare
|
@diasdavid we need this merged and released for ipfs/js-ipfs#1167 and ipfs-inactive/js-ipfs-http-client#652. |
This was referenced Jan 16, 2018
daviddias
approved these changes
Jan 19, 2018
|
thanks 🕺 ! |
daviddias
pushed a commit
that referenced
this pull request
Jan 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.