Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Test object.patch.rmLink cannot be run in isolation #189

Closed
alanshaw opened this issue Jan 1, 2018 · 3 comments
Closed

Test object.patch.rmLink cannot be run in isolation #189

alanshaw opened this issue Jan 1, 2018 · 3 comments
Assignees
@alanshaw
Labels
difficulty:easy help wanted P2 - Medium ready

Comments

@alanshaw
Copy link
Contributor

alanshaw commented Jan 1, 2018 •
edited

I was trying to run this test using it.only but couldn't. It's because it depends on the output from object.patch.addLink.

It requires testNodeWithLinkMultihash and testLink which are first defined in the .addLink test.
@daviddias
Copy link
Contributor

@alanshaw wanna submit a PR to make sure that the test does what it needs to be able to run in isolation?

@alanshaw alanshaw self-assigned this Jan 29, 2018
@alanshaw
Copy link
Contributor Author

It's on my stack

@daviddias daviddias mentioned this issue Feb 15, 2018
Open
@momack2 momack2 added this to Ready in ipfs/js-ipfs May 10, 2019
@momack2 momack2 added this to Ready in ipfs/js-waffle May 10, 2019
@achingbrain
Copy link
Collaborator

I think this has been done, please open a new issue against ipfs/js-ipfs if there's still a problem.

@hsanjuan hsanjuan removed this from Ready in ipfs/js-ipfs Apr 27, 2020
@hsanjuan hsanjuan removed this from Ready in ipfs/js-waffle Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alanshaw alanshaw

Labels
difficulty:easy help wanted P2 - Medium ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alanshaw @achingbrain @daviddias