Spec MFS Actions #206
Spec MFS Actions #206
Conversation
ghost
assigned 
|
@diasdavid just finished adding the specs for the MFS specific functions. Everything I wrote can be seen from here. Edit.: Probably I should write some tests too. |
SPEC/FILES.md
Outdated
| @@ -539,6 +539,252 @@ pull( | |||
|
|
|||
| A great source of [examples][] can be found in the tests for this API. | |||
|
|
|||
| #### `cp` | |||
There was a problem hiding this comment.
The MFS specific commands need a separator and an introduction to what MFS is.
There was a problem hiding this comment.
Okay @diasdavid. It makes sense. Although, there is a command (ls) that was already spec'ed and it says that it is only for MFS but that it should be implemented globally. See.
|
@diasdavid just added a separator and a brief description. Although, I think that you could help me improve this description if you don't mind 😄 |
|
@hacdias updated wording. Seems you confused |
|
Oh, it already said "files.ls" so I thought it would be the same. Thanks! I'll add the .Files.ls function today. |
|
Done @diasdavid 😄 |
|
Sweet! @hacdias can you add tests for these two? You will have to enable them to go-ipfs only. You can do it by checking: https://github.com/ipfs/interface-ipfs-core/blob/master/src/key.js#L33 |
|
@diasdavid tests done! 😄 They seem to work on ipfs-inactive/js-ipfs-http-client#675 |
src/files.js
Outdated
| describe('.mkdir', function () { | ||
| it('make directory on root', (done) => { | ||
| if (!withGo) { | ||
| console.log('Only supported by go-ipfs yet') |
There was a problem hiding this comment.
Not supported in js-ipfs yet would be better since those logs will only be printed when running js-ipfs tests.
src/files.js
Outdated
| @@ -980,5 +984,394 @@ module.exports = (common) => { | |||
| ) | |||
| }) | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
Can we break the MFS tests into another file? This test file is huge :)
There was a problem hiding this comment.
Do you think it should be added to index.js as a separate tests suit or should we just import them in files.js and there we would export them both?
Spec MFS functions: