This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: allow only by object #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only option will now accept an object for onlying a specific test.
Previously you could only do this to only run a specific test:
```js
{
only: ['should test a thing']
}
```
Now you can do this:
```js
{
only: [{
name: 'should test a thing',
reason: 'because development' // optional!
}]
}
```
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned
alanshaw
added a commit
to ipfs-inactive/js-ipfs-http-client
that referenced
this pull request
Dec 5, 2018
Not being applied because ipfs-inactive/interface-js-ipfs-core#407 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
Is this in a README somewhere? I find myself rummaging around in my memory/the codebase a lot for this sort of thing. |
|
yep its all in the README! https://github.com/ipfs/interface-ipfs-core/blob/master/README.md#running-only-some-tests |
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
Assuming this is ok....am merge. Shout if this is not what you wanted! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only option will now accept an object for onlying a specific test.
Previously you could only do this to only run a specific test:
Now you can do this:
License: MIT
Signed-off-by: Alan Shaw alan.shaw@protocol.ai