This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
refactor: reworks resolve tests with async/await #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Jul 24, 2019
This PR add IPNS support to resolve, makes the recursive option true by default and reworks the tests. Jsdocs were add to the resolve methods. Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet needs: ipfs-inactive/interface-js-ipfs-core#504
alanshaw
changed the title
alanshaw
approved these changes
Jul 25, 2019
hugomrdias
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Aug 1, 2019
This PR add IPNS support to resolve, makes the recursive option true by default and reworks the tests. Jsdocs were add to the resolve methods. Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet needs: ipfs-inactive/interface-js-ipfs-core#504
hugomrdias
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Aug 30, 2019
This PR add IPNS support to resolve, makes the recursive option true by default and reworks the tests. Jsdocs were add to the resolve methods. Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet needs: ipfs-inactive/interface-js-ipfs-core#504
hugomrdias
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Sep 3, 2019
This PR add IPNS support to resolve, makes the recursive option true by default and reworks the tests. Jsdocs were add to the resolve methods. Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet needs: ipfs-inactive/interface-js-ipfs-core#504
hugomrdias
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Sep 4, 2019
This PR add IPNS support to resolve, makes the recursive option true by default and reworks the tests. Jsdocs were add to the resolve methods. Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet needs: ipfs-inactive/interface-js-ipfs-core#504
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Sep 4, 2019
This PR adds IPNS support to resolve, makes the recursive option true by default and reworks the tests. Jsdocs were add to the resolve methods. Depends on: * [x] ipfs-inactive/interface-js-ipfs-core#504 BREAKING CHANGE: `recursive` is now `true` by default in `ipfs resolve`
hugomrdias
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Sep 5, 2019
This PR add IPNS support to resolve, makes the recursive option true by default and reworks the tests. Jsdocs were add to the resolve methods. Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet needs: ipfs-inactive/interface-js-ipfs-core#504
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.