This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: test ipns resolve of peerid as cid #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/libp2p/specs/blob/master/RFC/0001-text-peerid-cid.md License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This was referenced Nov 5, 2019
alanshaw
suggested changes
Nov 6, 2019
| @@ -45,6 +46,20 @@ module.exports = (createCommon, options) => { | |||
| .to.eq(`/ipfs/${path}`) | |||
| }) | |||
|
|
|||
| it('should resolve a record from peerid as cidv1 in base32', async function () { | |||
| this.timeout(20 * 1000) | |||
| const [{ path }] = await ipfs.add(Buffer.from('should resolve a record from cidv1b32')) | |||
There was a problem hiding this comment.
Would it be better to use hash here?
There was a problem hiding this comment.
...all the others are using path, lets leave it for another day!
hugomrdias
approved these changes
Nov 6, 2019
alanshaw
approved these changes
Nov 6, 2019
| @@ -45,6 +46,20 @@ module.exports = (createCommon, options) => { | |||
| .to.eq(`/ipfs/${path}`) | |||
| }) | |||
|
|
|||
| it('should resolve a record from peerid as cidv1 in base32', async function () { | |||
| this.timeout(20 * 1000) | |||
| const [{ path }] = await ipfs.add(Buffer.from('should resolve a record from cidv1b32')) | |||
There was a problem hiding this comment.
...all the others are using path, lets leave it for another day!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds IPFS test for resolving paths with libp2p-key represented as CIDv1 Base32.
Context:
cc libp2p/specs#216, https://github.com/ipfs/ipfs/issues/337