This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: do not assume certain implementations of ipfs are present #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing `type: 'js'` requires the containing project to have a dependency on js-IPFS which may not be the case.
achingbrain
changed the title
|
refs https://github.com/ipfs/interface-js-ipfs-core/issues/582#issuecomment-580215033 For |
ipfs-http-client tests might need to start a webrtc signalling server in the background.
I've added this to ipfs/js-ipfs#2729 in ipfs/js-ipfs@2b6f0e9 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
type: 'js'requires the containing project to have a dependency on js-IPFS which may not be the case.I don't think anything in these tests requires the js implementation. Please do shout if something does.