This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
refactor: convert utils to use async/await #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned
alanshaw
added a commit
that referenced
this pull request
Nov 10, 2018
NOTE: the PRs for ipfs/js-ipfs#1670 are being merged into the `feat/async-iterators` branch. Once they're all in we can merge them into master. --- This simply refactors the bitswap tests to use async/await and updates the documentation to remove callback support and propose a better method for documenting the parameters and return values. depends on #390 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: the PRs for ipfs/js-ipfs#1670 are being merged into the
feat/async-iteratorsbranch. Once they're all in we can merge them into master.I plan to submit a PR for each subsystem to keep them quick and easy to review.
This PR simply converts the modules in
js/src/utilsto use async/await.Also:
async- we're not going to need this anymore!chai-as-promisedfor easier assertions with promises