Add support for configurable pinning only on untrusted peers #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasrmichel
force-pushed
the
feat/1976-pin-only-on-untrusted-peers
branch
from
f013c43
to
90fd8c0
Compare
|
@hsanjuan -- I'd love your feedback on this feature. |
|
@hsanjuan -- Friendly nudge. 😄 I'd love your eyes and feedback on this feature PR. |
hsanjuan
approved these changes
Sep 29, 2023
|
Thank you @jonasrmichel . I wonder if you can document the new option by editing https://github.com/ipfs-cluster/ipfs-cluster-website/blob/master/content/documentation/reference/configuration.md. Other than that this LGTM. |
This was referenced Sep 29, 2023
|
Wonderful, thanks @hsanjuan. And good suggestion on the docs. See ipfs-cluster/ipfs-cluster-website#154 for the website docs update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1976
This PR adds support for pinning only on untrusted peers. This feature is enabled via a new
pin_only_on_untrusted_peersconfig setting (defaultfalse).Configuring both
pin_only_on_trusted_peersandpin_only_on_untrusted_peerstotrueresults in a config validation error.