Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection to Kubo via Unix domain socket fails with HTTP error #1999

Closed
ntninja opened this issue Nov 11, 2023 · 2 comments
Closed

Connection to Kubo via Unix domain socket fails with HTTP error #1999

ntninja opened this issue Nov 11, 2023 · 2 comments
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@ntninja
Copy link

ntninja commented Nov 11, 2023

Additional information:

  • OS: NixOS 23.05
  • IPFS Cluster version: 1.0.6
  • Installation method: NixOS repo

Describe the bug:

When setting ipfs_connector.ipfshttp.node_multiaddr to the Multiaddr of the Unix domain socket exposed by Kubo Nix package by default ("/unix/run/ipfs.sock") IPFS Cluster Service appears to successfully connect to the socket but fails to make any HTTP requests instead printing the following error for each request:

error posting to IPFS:Post "http:///run/ipfs.sock/api/v0/id": http: no Host in request URL

This is probably an encoding issue when generating the URL before passing it to whatever HTTP library is used by ipfs-cluster-service, since the encoded “request URL” should read as “http://%2Frun%2Fipfs.sock/api/v0/id” according to that URL RFC and hence have a hostname (even if unusual) set.

@ntninja ntninja added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Nov 11, 2023
@hsanjuan hsanjuan self-assigned this Nov 23, 2023
@hsanjuan hsanjuan removed the need/triage Needs initial labeling and prioritization label Nov 23, 2023
@hsanjuan hsanjuan added this to the Release v1.0.8 milestone Nov 23, 2023
@hsanjuan
Copy link
Collaborator

@ntninja can you try #2001 ?

@ntninja
Copy link
Author

ntninja commented Nov 23, 2023

Will do soon! Thanks!

hsanjuan added a commit that referenced this issue Dec 6, 2023
…kets

Fix #1999: Support talking to unix sockets in the ipfshttp connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants