ipfsproxy: use PinPath to match IPFS behaviour #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Closed
lanzafame
approved these changes
Mar 4, 2019
| @@ -55,8 +55,8 @@ func (rpcapi *RPCAPI) PinPath(ctx context.Context, in *api.PinPath, out *api.Pin | |||
| } | |||
|
|
|||
| // UnpinPath resolves path into a cid and runs Cluster.Unpin(). | |||
| func (rpcapi *RPCAPI) UnpinPath(ctx context.Context, in string, out *api.Pin) error { | |||
| pin, err := rpcapi.c.UnpinPath(ctx, in) | |||
| func (rpcapi *RPCAPI) UnpinPath(ctx context.Context, in *api.PinPath, out *api.Pin) error { | |||
There was a problem hiding this comment.
How can unpin utilize pinOptions?
There was a problem hiding this comment.
it doesn't, but for parallelism (allows using same code to call pin/unpin) and if at some point in history we can unpin with options it's marginally better this way.
hsanjuan
force-pushed
the
feat/proxy-with-pinpath
branch
2 times, most recently
from
f81edea
to
e4cd17b
Compare
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan
force-pushed
the
feat/proxy-with-pinpath
branch
from
0574ea8
to
23db807
Compare
kishansagathiya
approved these changes
Mar 4, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Hector Sanjuan hector@protocol.ai