Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

WIP feat: human option bitswap stat #1162

Closed
wants to merge 4 commits into from

Conversation

PedroMiguelSS
Copy link
Contributor

This PR adds human argument to api/v0/bitswap/stat that will be able to print sizes in human readable format (e.g., 1K 234M 2G)

E.g.:

curl "http://localhost:5001/api/v0/bitswap/stat?human=true"

⚠️It needs the following PR merged and released before this one can be:

@PedroMiguelSS PedroMiguelSS changed the title feat: human option bitswap stat WIP feat: human option bitswap stat Nov 18, 2019
@PedroMiguelSS
Copy link
Contributor Author

This PR will be closed as human option is only implemented on the CLI. See ipfs/js-ipfs#2619.

go-ipfs implements this feature only on the CLI and js-ipfs should implement it on the CLI as well for the sake of consistency.

@PedroMiguelSS PedroMiguelSS deleted the feat/human-option-bitswap-stat branch November 21, 2019 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant