Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Cannot append to end of file with CLI #53

Closed
alanshaw opened this issue Jun 14, 2019 · 0 comments · Fixed by #71 · May be fixed by adamlaska/ipfs-js-ipfs#2
Closed

Cannot append to end of file with CLI #53

alanshaw opened this issue Jun 14, 2019 · 0 comments · Fixed by #71 · May be fixed by adamlaska/ipfs-js-ipfs#2

Comments

@alanshaw
Copy link
Contributor

Seems to be the case for daemon on and daemon off:

js-ipfs:

$ echo "hello" | ipfs files write /test
$ ipfs files read /test
hello
$ echo "hello" | ipfs files write /test --offset=6
$ ipfs files read /test
hello

go-ipfs:

$ echo "hello" | ipfs files write /test
$ ipfs files read /test
hello
$ echo "hello" | ipfs files write /test --offset=6
$ ipfs files read /test
hello
hello
achingbrain added a commit that referenced this issue Jan 10, 2020
@achingbrain
fix: allow writing starting at offset beyond file length
11e7033 
There was a test for this but it didn't check the contents of the
entire file, only starting from the difference between the offset
and the file length.  Oops.

Fixes #53
@achingbrain achingbrain mentioned this issue Jan 10, 2020
Merged
achingbrain added a commit that referenced this issue Jan 10, 2020
@achingbrain
fix: allow writing starting at offset beyond file length (#71)
68bd372 
There was a test for this but it didn't check the contents of the
entire file, only starting from the difference between the offset
and the file length.  Oops.

Fixes #53
@snyk-bot snyk-bot mentioned this issue Mar 26, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@alanshaw