This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
feat: convert to async/await #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Ref: ipfs/js-ipfs#1670 |
4 tasks
|
Closes #7 |
alanshaw
suggested changes
Apr 30, 2019
| ``` | ||
|
|
||
| ### `maxDepth` | ||
| #### CBOR entries |
There was a problem hiding this comment.
hmm, interesting...
- Does it already support this?
- Does go-ipfs support this?
- Given that this is a unixfs exporter should we be supporting these IPLD node types?
There was a problem hiding this comment.
Yes, through the object exporter.
I'm not sure what go does.
The name starts to become misleading, true - might be worth turning it into a ipfs-exporter, though it's really an ipld-exporter with some baked in assumptions about dag-pb nodes? Not sure.
| const validateOffsetAndLength = require('../utils/validate-offset-and-length') | ||
|
|
||
| const rawContent = (node) => { | ||
| return function * (options = {}) { |
There was a problem hiding this comment.
I tend not to use this feature because it only works when undefined is passed and I usually also want to allow null to be passed (or any other falsey value really) so I end up doing the old options = options || {}. Kinda preference but also flexibility for the caller 🤷♀️
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the importer to
async/awaitpull-stream-to-async-iteratorasync/awaitRequires ipfs-inactive/js-ipfs-unixfs-importer#24 to be merged.