Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

feat: switch to async await #24

Merged
merged 4 commits into from May 17, 2019
Merged

feat: switch to async await #24

merged 4 commits into from May 17, 2019

Conversation

achingbrain
Copy link
Collaborator

@achingbrain achingbrain commented Apr 24, 2019 •
edited

Converts the importer to async/await

  • Shim importer with pull-stream-to-async-iterator
  • Convert tests to async/await
  • Convert importer to async/await and remove shim
  • Update README with API changes

Requires ipfs-inactive/js-ipfs-unixfs-exporter#21 to be merged

@ghost ghost assigned achingbrain Apr 24, 2019
@ghost ghost added the in progress label Apr 24, 2019
@achingbrain
Copy link
Collaborator Author

Ref: ipfs/js-ipfs#1670

@achingbrain achingbrain mentioned this pull request Apr 25, 2019
Merged
3 tasks
@alanshaw alanshaw mentioned this pull request Apr 29, 2019
Closed
alanshaw
alanshaw approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

src/utils/persist.js Outdated Show resolved Hide resolved
test/importer-flush.spec.js Outdated Show resolved Hide resolved
@alanshaw alanshaw mentioned this pull request May 13, 2019
Closed
13 tasks
@achingbrain achingbrain merged commit 2a40ecb into master May 17, 2019
@achingbrain achingbrain deleted the async-await branch May 17, 2019 11:32
@achingbrain achingbrain mentioned this pull request May 23, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees

@achingbrain achingbrain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achingbrain @alanshaw @whyrusleeping